Faster leading blank patterns #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this valid for |
rocky
added a commit
that referenced
this pull request
Sep 29, 2020
Rebase of Faster leading blank patterns #625
Member
I take it this is about improving coverage or improving performance furhter, not about whether this causes a bug. Assuming this is an overall improvement, it doesn't bother me that it isn't perfect. We can deal with perfection another time. If this was about being buggy, let us know. Or alternatively we'll realize that and deal with it down the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this while using
GatherBy; without this PR,x = Range[5000]; First[Timing[GatherBy[x, OddQ]]]evaluates to29.0664, with this PR this changes to0.517357.The basic problem is described in the comment in
yield_choice: sub patterns that are very expensive to check are tested, even though the Blank match should be obvious.Seems to give a very slight but measurable improvement in runtime.
master.txt
fastblank.txt