Adding some functions in numbertheory and arithmetic #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
larionvn
commented
Mar 29, 2017
larionvn
commented
- This PR includes the implementation of 3 functions:
- MantissaExponent
- FractionalPart
- CubeRoot
sn6uv
requested changes
Apr 4, 2017
mathics/builtin/arithmetic.py
Outdated
| attributes = {'Listable', 'NumericFunction', 'ReadProtected'} | ||
|
|
||
| rules = { | ||
| 'CubeRoot[n_]': 'If[NumericQ[n] == True, If[n > 0, Power[n, Divide[1, 3]], Times[-1, Power[Times[-1, n], Divide[1, 3]]], Power[n, Divide[1, 3]]], Power[n, Divide[1, 3]]]', |
Member
There was a problem hiding this comment.
What about Complex numbers (which are NumericQ)? It looks like CubeRoot only acts on reals. I think this can be cleaned up a bit.
Contributor
Author
There was a problem hiding this comment.
Thanks for your feedback @sn6uv . The tests were failed due to some problems on the Travis_ci side. I've passed all the testcases (on Travis_ci) with the same source code before. For the Complex numbers case, I've checked on the Mathematica and see that the CubeRoot still work with Complex number except they throw a warning message. Anyway, I will push the new source code for handling that warning message soon.
Member
|
rebased and will be merged once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.