Added Delete command #784
Merged
Added Delete command #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhr
reviewed
Jul 10, 2019
mathics/builtin/lists.py
Outdated
| return Expression('List', *results) | ||
|
|
||
| def del_part(expr,indices,evaluation): | ||
| def del_one(cur,pos): |
Contributor
There was a problem hiding this comment.
Is it really necessary to put a function inside a function?
Contributor
Author
There was a problem hiding this comment.
I wouldn't say it's "necessary", no. But these are just helper functions that are not intended to be called outside the function del_part, so they are local to that scope, and the same idiom is used elsewhere in the lists.py source (e.g., in get_part, set_part, and Array.apply)
I've now put all three helper functions into the Delete object. Is that better?
Contributor
There was a problem hiding this comment.
Is that better?
I believe so.
suhr
reviewed
Jul 10, 2019
| return cur | ||
| else: | ||
| raise PartRangeError | ||
| def del_rec(self, cur, rest): |
Contributor
Author
There was a problem hiding this comment.
oops, I missed this.
mathics/builtin/lists.py
Outdated
| def del_rec(self, cur, rest): | ||
| if cur.is_atom(): | ||
| raise PartDepthError | ||
| if len(rest)>1: |
suhr
reviewed
Jul 11, 2019
| raise PartRangeError | ||
| else: | ||
| return self.del_one(cur, rest[0]) | ||
| def del_part(self, expr,indices,evaluation): |
Contributor
There was a problem hiding this comment.
And here should be a newline too.
Contributor
Member
|
Great! Fantastic contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing Delete command.