Skip to content

Conversation

@mmatera
Copy link
Contributor

@mmatera mmatera commented Sep 28, 2020

rebase (and a lot of fixings) of #619

mmatera and others added 20 commits September 28, 2020 18:35
Information functions support

more efficient last definition checks
cleanup

fixes typo bug
cleanup

more write protection stuff
adds comments

comments, better cost handling for Expression.output_cost
cleanup

more cleanups

docs for slice(), filter(), restructure(), cleanups

replaced last_evaluated, _symbols by _token

fixes small bug

fix options pattern rules
fix _flatten_sequence evaluation parameter

fixes bug: _leaves must always be a tuple
… use in loops

fixes DeleteStopWords

several fixes

fixing error in appending leaves   in algebra.py

fixing list<>tuple

fixing list<>tuple in numeric

fixing parameter name in list.py

fix?

reformulate Delete

erase duplicated class Delete

Delete completely fixed...

CoefficientList completely fixed...

Quantities completely fixed...

Quantities completely fixed...

Quantities completely fixed...

Quantities completely fixed...

Quantities and get_part completely fixed...

Fix RealDigits

Fix ReplacePart

fixes
@mmatera mmatera changed the title Qtime Rebase of Fix quadratic runtimes in Mathics (#619) Sep 28, 2020
@rocky
Copy link
Member

rocky commented Sep 29, 2020

This is fantastic! Please give me a couple of days to look this over in more detail. Thanks!

@mmatera
Copy link
Contributor Author

mmatera commented Sep 29, 2020

Do not hurry: it was sleeping for 3 years and could wait a few days more...

@rocky
Copy link
Member

rocky commented Sep 29, 2020

@mmatera I think I added the merge conflict with a recent commit from one of the PRs. I'm sorry. If you have the time would you rebase this?

Also, since you are a member it would be great if you worked off of a branch in this repository rather than the mmatera fork. (The branch name could be the same name though). That makes it easier for others who have access to try the code out and fix on top of the branch.

Again, sorry for the additional work. Thanks!

poke1024 and others added 3 commits September 30, 2020 09:53
cleanup

fixes nasty cache bug

optimize_blanks for faster matching in certain situations

fixes Orderless patterns

fixes for orderless expressions
Fix PR#685

Refactor code for Subsets[] function

Handling the non list argument in the 1st position for Subsets[]

Update Subsets[] for finding subsets from any head in Mathics

Revise CHANGEs.rst; \\[ escape
new attempt...

new try

working now

fix
@mmatera
Copy link
Contributor Author

mmatera commented Sep 30, 2020

I think I have fixed this in the qtime branch of this repository. I will close this PR and I invite you to look at that branch.

@mmatera mmatera closed this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants