Skip to content

Qtime #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rocky merged 28 commits into from
Oct 2, 2020
Merged

Qtime #936

rocky merged 28 commits into from
Oct 2, 2020

Conversation

@mmatera
Copy link
Contributor

@mmatera mmatera commented Sep 30, 2020

Let's go again...

mmatera and others added 26 commits September 28, 2020 18:35
@mmatera
fixing Information
9417a90 
Information functions support

more efficient last definition checks
@poke1024 @mmatera
only convert to set if needed
c6fa542 
cleanup

fixes typo bug
@poke1024 @mmatera
write protection for Expression.leaves
8add595 
cleanup

more write protection stuff
@poke1024 @mmatera
fixes tuple incompatibilities
b87149f 
adds comments

comments, better cost handling for Expression.output_cost
@poke1024 @mmatera
introduce restructure()
c8dcb19
@poke1024 @mmatera
introduction of Structure (a work in progress)
5c23eb9
@poke1024 @mmatera
Structure is now faster; _list_parts now uses Structure
75c94bb 
cleanup

more cleanups

docs for slice(), filter(), restructure(), cleanups

replaced last_evaluated, _symbols by _token

fixes small bug

fix options pattern rules
@poke1024 @mmatera
improvements to general runtime
5385407
@poke1024 @mmatera
changed all internal accesses to leaves to Expression._leaves
b257965 
more general performance fixes
@poke1024 @mmatera
use self._head for private access to Expression head
51711fc
@poke1024 @mmatera
simpler and faster set handling in Expression._prepare_symbols()
70bd86c 
fixes missing update in _prepare_symbols
@poke1024 @mmatera
massive improvement for large lists (again)
7c97d0f 
fix _flatten_sequence evaluation parameter

fixes bug: _leaves must always be a tuple
@poke1024 @mmatera
added _no_symbol()
16e4405
@poke1024 @mmatera
set_leaves renamed to set_leaf
2402a26
@poke1024 @mmatera
unification with _sequences
5980cf7
@poke1024 @mmatera
better names, documentation, cleanup
bbff7f4
@poke1024 @mmatera
Sort now uses restructure
914e068
@poke1024 @mmatera
added atom_list, string_list
bc31a2a 
fixes test cases
@poke1024 @mmatera
made atom_list into an atom_list_constructor; this is much better for…
4564d78 
… use in loops

fixes DeleteStopWords

several fixes

fixing error in appending leaves   in algebra.py

fixing list<>tuple

fixing list<>tuple in numeric

fixing parameter name in list.py

fix?

reformulate Delete

erase duplicated class Delete

Delete completely fixed...

CoefficientList completely fixed...

Quantities completely fixed...

Quantities completely fixed...

Quantities completely fixed...

Quantities completely fixed...

Quantities and get_part completely fixed...

Fix RealDigits

Fix ReplacePart

fixes
@mmatera
pep8 and removing duplicated class Information for n-esim time...
dc86be7
@poke1024 @mmatera
added format cache
32e4415 
cleanup

fixes nasty cache bug

optimize_blanks for faster matching in certain situations

fixes Orderless patterns

fixes for orderless expressions
@larionvn @mmatera
Add Subsets[]
0acae72 
Fix PR#685

Refactor code for Subsets[] function

Handling the non list argument in the 1st position for Subsets[]

Update Subsets[] for finding subsets from any head in Mathics

Revise CHANGEs.rst; \\[ escape
@mmatera
fix formatcache
7047e76 
new attempt...

new try

working now

fix
@mmatera
fix last_evaluated
7a9f83a
@mmatera
fixing format_cache for sublist changes
dcaf693
@mmatera
Merge branch 'master' into qtime
cc9dd82
@rocky
Copy link
Member

rocky commented Sep 30, 2020

Thanks! There are lots of changes. I'm curious if we can see the promised speed up.

@mmatera
Copy link
Contributor Author

mmatera commented Oct 1, 2020

I guess the advantage is apparent from the time that the tests take. On the other hand, there is also an advantage in memory, because this evaluation method does not require to keep the frames for each call in the arguments at the same time...

@mmatera
Copy link
Contributor Author

mmatera commented Oct 1, 2020

By the way, we need to fix the travis check to detect the fails. As it is now, if some symbols fails, the tests still pass in green...

@mmatera
Copy link
Contributor Author

mmatera commented Oct 1, 2020

Well, it seems that now again it passes all the tests. I leave this here until the weekend, and then we can decide if we keep it or not.

@rocky
Copy link
Member

rocky commented Oct 1, 2020

Again, thanks.

@rocky
Copy link
Member

rocky commented Oct 2, 2020 •
edited
Loading

I've looked this over and don't see anything glaring. I was also able to confirm the after resuls @poke1024 gave in #619.

The before results (quadratic behavior) I had a hard time verifying I verified by going back to the 1.0 tag. Indeed it is quadratic.

So let's go with this, and if there are problems down the line we'll deal with it then.

@rocky rocky merged commit 93cb0eb into master Oct 2, 2020
@rocky rocky deleted the qtime branch October 2, 2020 22:23
@rocky rocky mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mmatera @rocky @GarkGarcia @poke1024 @larionvn