Support for comparisons between SympyConstants #982
Conversation
There was a problem hiding this comment.
I may be wrong, but there seem to be a few unrelated changes in a few files. And a removed picture in the documentation.
Could you go over them?
It'd also be helpful if you could fix the tests and add a few new ones. I'll take a look at this tommo and maybe try to help.
mathics/builtin/__init__.py
Outdated
| graphics, graphics3d, | ||
| image, inout, integer, iohooks, linalg, lists, logic, | ||
| # image, | ||
| inout, integer, iohooks, linalg, lists, logic, |
There was a problem hiding this comment.
This right here is what I'm talking about.
There was a problem hiding this comment.
Yes, my mistake. I always comment out this module for local testings...
There was a problem hiding this comment.
No probs, nobody's perfect!
I'm assuming the removed picture is also not intentional; add that back too?
GarkGarcia
changed the title
rocky
force-pushed
the
master
branch
7 times, most recently
from
ab12a77 to
6525df7
Compare
|
This wouldn't really work for something like |
No as it is. This PR requires more work, but I didn't find the time to do it. The idea was first to identify where in the code the comparison is done, and then, look for the smartest way to extend it using sympy. |
I think I'll try working on it later today. |
rocky
force-pushed
the
master
branch
3 times, most recently
from
7a4d68a to
d41fae8
Compare
|
@mmatera is this still relevant? |
Add support to compare SympyConstants