Skip to content

fix(hints): trim implementation-leak wiring from 2 Caveat strings #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunallanjewar merged 1 commit into from
Apr 23, 2026
Merged

fix(hints): trim implementation-leak wiring from 2 Caveat strings #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/hints/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ type Rule struct {
//
// Rule order here is not semantically meaningful: the Engine keys on
// Rule.ID after loading DB metadata via Store.LoadRules.
//
// Rule TriggerTool values are matched against ev.Tool after both sides
// pass through quest.CanonicalToolName, so rules authored against the
// canonical name (e.g. quest_fulfill) also match backward-compat aliases
// (e.g. quest_clear). Add new aliases in internal/quest/aliases.go; the
// normalization call site lives in Engine.Evaluate (engine.go).
func Definitions() []Rule {
return []Rule{
// 💡 hint (keep) — 6 rules.
Expand Down Expand Up @@ -82,7 +88,7 @@ func Definitions() []Rule {
TriggerTool: "quest_fulfill",
Trigger: triggerNoBrief24h,
FollowThrough: followQuestBrief,
Caveat: "Era-aware severity: 💡 hint on MCP, ℹ️ fyi on Bash CLI (18.7pp gap in ENTRY-29 calibration). TriggerTool is canonical quest_fulfill; quest_clear alias is handled by quest.CanonicalToolName in the engine.",
Caveat: "Era-aware severity: 💡 hint on MCP, ℹ️ fyi on Bash CLI (18.7pp gap in ENTRY-29 calibration).",
},

// ℹ️ fyi (demote) — 3 rules.
Expand All @@ -98,7 +104,7 @@ func Definitions() []Rule {
TriggerTool: "quest_fulfill",
Trigger: triggerClearWithoutReportDetail,
FollowThrough: followQuestUpdateOrJournal,
Caveat: "Demoted to fyi; short reports are legitimate for trivial clears. TriggerTool is canonical quest_fulfill; quest_clear alias is handled by quest.CanonicalToolName in the engine.",
Caveat: "Demoted to fyi; short reports are legitimate for trivial clears.",
},
{
ID: "principle-too-long",
Expand Down
Loading