Skip to content

Add pandas package to appveyor configuration#8657

Merged
QuLogic merged 1 commit intomatplotlib:masterfrom
fkohlgrueber:ci
May 28, 2017
Merged

Add pandas package to appveyor configuration#8657
QuLogic merged 1 commit intomatplotlib:masterfrom
fkohlgrueber:ci

Conversation

@fkohlgrueber
Copy link
Copy Markdown
Contributor

PR Summary

I appended pandas to the list of packages that are installed into the conda environment that's used for testing on Appveyor.

This lets all tests that depend on pandas run (currently 7). Two of the Travis CI jobs already include pandas and I think that there's no reason not to run these tests on Appveyor as well. Please tell me if there are any.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone May 23, 2017
@tacaswell
Copy link
Copy Markdown
Member

Thanks for contribution!

My only concern is if the pandas tests add significant overhead (as appevyor is already very slow). 👍 if this adds < 30s to the run time.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented May 28, 2017

Comparing with a random build from master, this PR is 3 minutes slower, but comparing with a random build from a different PR, this PR is 12 minutes faster. So I think whatever the difference is, it's well within the variance of AppVeyor build times. I'll take @tacaswell's conditional 👍 as granted, then.

@QuLogic QuLogic merged commit 5f2d4dd into matplotlib:master May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants