Test validation on send_{join,knock,leave}#132
Merged
Conversation
richvdh
force-pushed
the
rav/send_membership_validation
branch
2 times, most recently
from
5720120 to
b17977c
Compare
Member
Author
|
|
richvdh
force-pushed
the
rav/send_membership_validation
branch
from
b17977c to
aa2be20
Compare
babolivier
suggested changes
Jul 1, 2021
|
|
||
| // SupportedRoomVersions is a convenience method which returns a list of the room versions supported by gomatrixserverlib. | ||
| func SupportedRoomVersions() []gomatrixserverlib.RoomVersion { | ||
| supportedRoomVersions := make([]gomatrixserverlib.RoomVersion, 0, 10) |
Contributor
There was a problem hiding this comment.
Why a capacity of 10 ooc?
Member
Author
There was a problem hiding this comment.
good question. mostly because I forgot that capacity was optional.
Member
Author
There was a problem hiding this comment.
... though this change has come from #131 rather than here.
richvdh
force-pushed
the
rav/send_membership_validation
branch
from
86fa3f3 to
187fb5b
Compare
erikjohnston
approved these changes
Jul 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some tests that try sending things other than proper events via
send_{join,knock,leave}