Fix race in MSC3083 TestRestrictedRoomsRemoteJoin#149
Conversation
This was broken by matrix-org/synapse#10272
| bob.LeaveRoom(t, room) | ||
| bob.LeaveRoom(t, space) | ||
|
|
||
| alice.SyncUntilTimelineHas(t, space, func(ev gjson.Result) bool { |
There was a problem hiding this comment.
I wonder if having LeaveRoom is a mistake, and we should make a LeaveRoomSynced to do this always.
There was a problem hiding this comment.
Maybe, though the subtlety here is that we need to wait for it to be processed on the remote server, rather than the local one.
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
it kinda looks fine, but I don't quite follow why alice needs to see the leave for the test to continue?
I've added a comment, but basically Bob would leave the space and then try to join the original room again before the remote server saw him leave the space, so the remote server accepted the join when we were expecting it to fail. |
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
3 participants
This was broken by matrix-org/synapse#10272