Test the updated MSC2946 room hierarchy endpoint.#187
Merged
Conversation
clokep
force-pushed
the
clokep/spaces-pagination
branch
3 times, most recently
from
7303b67 to
6943f26
Compare
clokep
force-pushed
the
clokep/spaces-pagination
branch
from
6943f26 to
c359e5a
Compare
richvdh
approved these changes
Aug 10, 2021
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
lgtm.
Only thing I'd suggest is adding comments next to the old /rooms/{room}/spaces tests to say that they are due for removal.
clokep
force-pushed
the
clokep/spaces-pagination
branch
from
5071ca2 to
7d40874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for matrix-org/synapse#10549.
I opted to not remove the old tests for now since both endpoints are going to exist in conjunction right now. We should remoe those in the future when removing support for the old endpoint.