Bind HS containers to 127.0.0.1#318
Merged
Merged
Conversation
Otherwise on some machines they can bind to both IPv4 and IPv6 addresses which could cause port confusion. Rather than binding to 0.0.0.0 which we don't need, just bind to 127.0.0.1.
neilalexander
approved these changes
Feb 16, 2022
kegsay
added a commit
to matrix-org/synapse
that referenced
this pull request
Mar 24, 2022
The issues which meant concurrency caused flakey tests has been resolved for over a month now without issue ( matrix-org/complement#318 ) so it's safe to re-enable this for Synapse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise on some machines they can bind to both IPv4 and IPv6
addresses which could cause port confusion. Rather than binding
to 0.0.0.0 which we don't need, just bind to 127.0.0.1.