Skip to content

Remove knocking build flag and Synapse's experimental config option #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anoadragon453 merged 7 commits into from
Mar 29, 2022
Merged

Remove knocking build flag and Synapse's experimental config option #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f8e3e94
Remove build flag and update comment for knocking tests
anoadragon453 Mar 4, 2022
92d148e
Rename msc2403_test -> knocking_test
anoadragon453 Mar 4, 2022
cfabfd8
Remove msc2403 build flag from Synapse dockerfile
anoadragon453 Mar 4, 2022
9933ee4
Remove msc2403_enabled experimental flag from Synapse config
anoadragon453 Mar 4, 2022
3d70e8f
Blacklist knocking tests on Dendrite
anoadragon453 Mar 10, 2022
2a7f1d3
Merge branch 'main' into anoa/stabilise_msc2403
kegsay Mar 23, 2022
c71f22f
Merge branch 'main' into anoa/stabilise_msc2403
kegsay Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
matrix:
include:
- homeserver: Synapse
tags: synapse_blacklist,msc2403,msc3083
tags: synapse_blacklist,msc3083

- homeserver: Dendrite
tags: msc2836 dendrite_blacklist
Expand Down
2 changes: 0 additions & 2 deletions dockerfiles/synapse/homeserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ AS_REGISTRATION_FILES
## Experimental Features ##

experimental_features:
# Enable knocking support
msc2403_enabled: true
# Enable spaces support
spaces_enabled: true
# Enable history backfilling support
Expand Down
2 changes: 0 additions & 2 deletions dockerfiles/synapse/workers-shared.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ federation_rr_transactions_per_room_per_second: 9999
## Experimental Features ##

experimental_features:
# Enable knocking support
msc2403_enabled: true
# Enable history backfilling support
msc2716_enabled: true
# Enable spaces support
Expand Down
8 changes: 5 additions & 3 deletions tests/msc2403_test.go → tests/knocking_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// +build msc2403
// Knocking is not yet implemented on Dendrite
//go:build !dendrite_blacklist
Comment thread
anoadragon453 marked this conversation as resolved.
// +build !dendrite_blacklist

// This file contains tests for knocking, a currently experimental feature defined by MSC2403,
// which you can read here: https://github.com/matrix-org/matrix-doc/pull/2403
// This file contains Client-Server and Federation API tests for knocking
// https://spec.matrix.org/1.2/client-server-api/#knocking-on-rooms

package tests

Expand Down