Enable arbitrary env vars to be propagated to Complement containers#382
Merged
Conversation
Fixes #6 This PR adds a new complement env var called `COMPLEMENT_SHARE_ENV_PREFIX`. This can be set to any string e.g `FOO_`. If it is set, Complement will look at the host environment for any env var with this prefix. If it finds it, it will remove the prefix and add it to the Complement container. For example, with a host env: ``` COMPLEMENT_SHARE_ENV_PREFIX=FOO_ FOO_DENDRITE_TRACE_HTTP=1 ``` This will cause `DENDRITE_TRACE_HTTP=1` to be set in the Complement container. This addresses 2 desires: - The ability to ad-hoc set debugging env vars when a test is failing e.g to use `os.Setenv("DENDRITE_TRACE_HTTP", "1")` in a test to get more logging. - The ability to pass through arbitrary data to a Synapse container, as requested by @reivilibre
reivilibre
approved these changes
May 27, 2022
Contributor
reivilibre
left a comment
reivilibre
left a comment
There was a problem hiding this comment.
LGTM — lovely thank you :)
reivilibre
added a commit
that referenced
this pull request
Jun 14, 2022
reivilibre
added a commit
that referenced
this pull request
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
This PR adds a new complement env var called
COMPLEMENT_SHARE_ENV_PREFIX.This can be set to any string e.g
FOO_. If it is set, Complement willlook at the host environment for any env var with this prefix. If it finds
it, it will remove the prefix and add it to the Complement container.
For example, with a host env:
This will cause
DENDRITE_TRACE_HTTP=1to be set in the Complement container.This addresses 2 desires:
e.g to use
os.Setenv("FOO_DENDRITE_TRACE_HTTP", "1")in a test to get more logging.by @reivilibre