partial state tests: factor out room creation#429
Merged
Conversation
squahtx
approved these changes
Jul 27, 2022
Contributor
squahtx
left a comment
squahtx
left a comment
There was a problem hiding this comment.
The last two commits look reasonable!
This will give tests the flexibility to create rooms themselves.
now that this is factored out, let's use it.
richvdh
force-pushed
the
rav/partial_state_factor_out_create_room
branch
from
dbbcd8d to
8f75c53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor the creation of the server and the room from
beginPartialStateJoin. It was handy there, but is too restrictive for tests that need to mess about with the room before the join.Based on #418