Skip to content

Faster room joins: Add abandoned join tests for device list tracking#476

Merged
erikjohnston merged 8 commits into
mainfrom
squah/faster_room_joins_device_list_tracking_incoming_2
Oct 13, 2022
Merged

Faster room joins: Add abandoned join tests for device list tracking#476
erikjohnston merged 8 commits into
mainfrom
squah/faster_room_joins_device_list_tracking_incoming_2

Conversation

@squahtx
Copy link
Copy Markdown
Contributor

@squahtx squahtx commented Sep 23, 2022

This change tests device list tracking when a partial state room is left
before the partial state join completes. Leaving a partial state room
is not currently implemented in Synapse.


Built on top of #475.

@squahtx squahtx requested review from a team as code owners September 23, 2022 18:29
@squahtx squahtx changed the base branch from main to squah/faster_room_joins_device_list_tracking_incoming_1 September 23, 2022 18:29
@squahtx squahtx force-pushed the squah/faster_room_joins_device_list_tracking_incoming_2 branch from 625a9ed to c53dda4 Compare September 23, 2022 18:45
@squahtx squahtx force-pushed the squah/faster_room_joins_device_list_tracking_incoming_1 branch from 7526731 to 58dfb70 Compare September 23, 2022 18:45
Base automatically changed from squah/faster_room_joins_device_list_tracking_incoming_1 to main September 29, 2022 13:42
Comment thread tests/federation_room_join_partial_state_test.go
Comment thread tests/federation_room_join_partial_state_test.go Outdated
Comment thread tests/federation_room_join_partial_state_test.go
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@squahtx squahtx requested a review from richvdh September 30, 2022 13:40
@richvdh richvdh removed their request for review October 3, 2022 11:36
@squahtx squahtx requested a review from richvdh October 4, 2022 15:55
@DMRobertson DMRobertson requested a review from a team October 10, 2022 14:22
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit 2029b1e into main Oct 13, 2022
@erikjohnston erikjohnston deleted the squah/faster_room_joins_device_list_tracking_incoming_2 branch October 13, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants