Add pushrule sync tests#488
Merged
Merged
Conversation
S7evinK
force-pushed
the
s7evink/pushsync
branch
from
5dfb19b to
ab5423f
Compare
S7evinK
force-pushed
the
s7evink/pushsync
branch
from
ab5423f to
bf1e029
Compare
squahtx
reviewed
Oct 7, 2022
squahtx
approved these changes
Oct 7, 2022
Contributor
There was a problem hiding this comment.
Thanks for updating the comment. The PR largely looks good.
I completely missed that we neglect to close the channels, good spot.
I'm not fully convinced the timeouts are worth the additional complexity, especially if we think they are impossible to hit, but won't block the PR on it.
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the tests from tests/61push/06_push_rules_in_sync.pl