Skip to content

Sytest: Add 30rooms/22profile test#511

Merged
kegsay merged 1 commit into
matrix-org:mainfrom
ShadowJonathan:30rooms/22profile
Oct 19, 2022
Merged

Sytest: Add 30rooms/22profile test#511
kegsay merged 1 commit into
matrix-org:mainfrom
ShadowJonathan:30rooms/22profile

Conversation

@ShadowJonathan
Copy link
Copy Markdown
Contributor

This adds one sytest:

  • ./tests/30rooms/22profile.pl: test "$datum updates affect room member events",

This also alters SyncJoinedTo in a backwards-compatible way to receive additional check functions, to check on the event of the join, this could be useful for things like restricted room joins, or - in this case - checking changed membership profile data.

@ShadowJonathan ShadowJonathan requested review from a team and kegsay as code owners October 15, 2022 11:24
Comment thread internal/client/client.go
@ShadowJonathan ShadowJonathan changed the title Sytest: Add 30rooms/22profile tests Sytest: Add 30rooms/22profile test Oct 15, 2022
Comment thread tests/csapi/room_profile_test.go
@kegsay kegsay merged commit 5c243d9 into matrix-org:main Oct 19, 2022
@ShadowJonathan
Copy link
Copy Markdown
Contributor Author

ShadowJonathan commented Oct 19, 2022

Re MXC validation: i asked about this in the homeservers room but i got no response, seeing how the spec is also silent on it (on explicitly validating it), and the sytest negatively asserts it with this, i added it like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants