Skip to content

Expect heroes in partial join response #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DMRobertson merged 1 commit into from
Nov 15, 2022
Merged

Expect heroes in partial join response #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions tests/federation_room_join_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,17 +509,26 @@ func TestSendJoinPartialStateResponse(t *testing.T) {
returnedStateEventKeys = append(returnedStateEventKeys, typeAndStateKeyForEvent(gjson.ParseBytes(ev)))
}
must.CheckOffAll(t, returnedStateEventKeys, []interface{}{
"m.room.create|", "m.room.power_levels|", "m.room.join_rules|", "m.room.history_visibility|",
"m.room.create|",
"m.room.power_levels|",
"m.room.join_rules|",
"m.room.history_visibility|",
// Expect Alice and Bob's membership here because they're room heroes
"m.room.member|" + alice.UserID,
"m.room.member|" + bob.UserID,
})

// check the returned auth events match those expected
// check the returned auth events match those expected.
// Now that we include heroes in the partial join response,
// all of the events are included under "state" and so we don't expect any
// extra auth_events.
// TODO: add in a second e.g. power_levels event so that we add stuff to the
// auth chain.
var returnedAuthEventKeys []interface{}
for _, ev := range sendJoinResp.AuthEvents {
returnedAuthEventKeys = append(returnedAuthEventKeys, typeAndStateKeyForEvent(gjson.ParseBytes(ev)))
}
must.CheckOffAll(t, returnedAuthEventKeys, []interface{}{
"m.room.member|" + alice.UserID,
})
must.CheckOffAll(t, returnedAuthEventKeys, []interface{}{ })

// check the server list. Only one, so we can use HaveInOrder even though the list is unordered
must.HaveInOrder(t, sendJoinResp.ServersInRoom, []string{"hs1"})
Expand Down