Add tests for MSC3930: polls push rules#578
Merged
anoadragon453 merged 8 commits intomainfrom Jan 18, 2023
Merged
Conversation
Some helper methods to get and set push rules.
Found while traversing the codebase.
anoadragon453
commented
Jan 6, 2023
Comment on lines
+180
to
+181
| // TODO: Test whether the homeserver correctly calls POST /_matrix/push/v1/notify on the push gateway | ||
| // in accordance with the push rules. Blocked by Complement not having a push gateway implementation. |
Member
Author
There was a problem hiding this comment.
Heads up: I don't intend to fix this in this PR, since it requires the heavy chunk of work of making Complement support handling the Push Gateway API. The known implementations of matrix-org/matrix-spec-proposals#3930 are currently intending to process push rules entirely client-side anyways.
squahtx
approved these changes
Jan 11, 2023
Contributor
squahtx
left a comment
squahtx
left a comment
There was a problem hiding this comment.
Looks good, just a few minor comments and questions.
The comments describing what the push rules do are really helpful!
squahtx
reviewed
Jan 13, 2023
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for MSC3930. It queries the default push rules from the homeserver and verifies the content and ordering of the push rules defined in MSC3930.
This PR is based on #577. This PR has now been rebased onmain.