Skip to content

Print Complement test failures at the bottom of the test output#606

Merged
DMRobertson merged 1 commit into
matrix-org:mainfrom
realtyem:gotestfmt
Feb 13, 2023
Merged

Print Complement test failures at the bottom of the test output#606
DMRobertson merged 1 commit into
matrix-org:mainfrom
realtyem:gotestfmt

Conversation

@realtyem
Copy link
Copy Markdown
Contributor

@realtyem realtyem commented Feb 11, 2023

Skipped tests too. Credit is not mine, just duplicating what I saw in the Synapse repository.
Fixes #589

Pull Request Checklist

Signed-off-by: Jason Little realtyem@gmail.com

@realtyem realtyem requested review from a team as code owners February 11, 2023 21:33
@sumnerevans
Copy link
Copy Markdown
Contributor

Where is this in the Synapse repository?

@realtyem
Copy link
Copy Markdown
Contributor Author

Where is this in the Synapse repository?

The file layout is the same. The template is in .ci and the gotestfmt wrapper script is is .ci/scripts. Here's the permalinks:

Sorry for making extra directory's. The only other script place I saw was for build scripts, which this didn't feel right for.

Copy link
Copy Markdown
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, it's been a bugbear of mine for some time.

@DMRobertson DMRobertson merged commit 86abf93 into matrix-org:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard to find test failures in CI ouput

3 participants