Drop attachment requirements for media download#646
Merged
Conversation
Fix operand
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
I thought inline media still had file names?
Also, can we add a test for ensuring that a known unsafe (e.g. pdfs?) content is returned as an attachment? I know its not specced, but it is a security thing so I'd like not to lose the test. We can always mark it as synapse specific.
Co-authored-by: Erik Johnston <erik@matrix.org>
Collaborator
Author
|
@kegsay has been review requested because of the SVG file, but I'm unsure how much he cares to review it. Of course, more than welcome :) |
clokep
reviewed
Aug 24, 2023
Member
|
I updated this to handle the remaining review comments. I think this is ready for another review. |
erikjohnston
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #645
For matrix-org/synapse#15988