Start adding tests for MSC4140#734
Conversation
as it is currently unused
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Great work so far! Tests are clear and easy to read.
| deployment.StopServer(t, hsName) | ||
| time.Sleep(1 * time.Second) | ||
| deployment.StartServer(t, hsName) |
There was a problem hiding this comment.
I worry that Synapse may not always start in 10s, especially when running with a ton of workers. See the list of workers we run in the Synapse repo's Complement CI.
Unfortunately it doesn't look like we're testing with Synapse workers in Complement's CI. Have you tried running with workers locally? Otherwise, perhaps we can just merge these tests and see how they do on the Synapse PR's CI?
There was a problem hiding this comment.
I've done some light local testing with workers, though not in Complement runs.
There was a problem hiding this comment.
Let's merge it and see, I suppose. We can always bump this timeout as a quick fix before converting it to a unit test, if necessary.
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
This LGTM! Thanks for addressing the changes.
| deployment.StopServer(t, hsName) | ||
| time.Sleep(1 * time.Second) | ||
| deployment.StartServer(t, hsName) |
There was a problem hiding this comment.
Let's merge it and see, I suppose. We can always bump this timeout as a quick fix before converting it to a unit test, if necessary.
2 participants
Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Pull Request Checklist