Add tests for MSC4155#782
Merged
Merged
Conversation
3 tasks
kegsay
reviewed
Jun 2, 2025
kegsay
reviewed
Jun 2, 2025
anoadragon453
requested changes
Jun 3, 2025
Member
anoadragon453
left a comment
There was a problem hiding this comment.
The existing tests look great! Thanks for compiling these on top of Synapse's unit tests.
Could you add a few more sanity checks:
- A field present, but set to
null, is treated as an empty array. - A user being in both
allowed_usersandblocked_usersshould allow the user. - Glob-style matching that uses a
?to represent a single character (spec) - Escaping a glob works, so you can match a user with ID
@*?:example.com(which is allowed under the historical user ID spec.
Collaborator
Author
These are done, with the exception of EDIT We agreed to ignore this for now, as matrix-org/matrix-spec#2156 is a problem. |
anoadragon453
approved these changes
Jun 3, 2025
Member
anoadragon453
left a comment
There was a problem hiding this comment.
This now LGTM. Thank you for doing this!
jevolk
pushed a commit
to matrix-construct/complement
that referenced
this pull request
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For element-hq/synapse#18288
This implements tests for matrix-org/matrix-spec-proposals#4155
Tests will not pass as I do not have rights to push to element-hq/Synapse, so it won't be able to find my branch.
Pull Request Checklist