Add tests for rich topic handling (previously MSC3765)#788
Merged
Conversation
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
3 tasks
MadLittleMods
approved these changes
Jul 9, 2025
Comment on lines
+99
to
+100
| // POST /createRoom makes a room with a topic via initial_state overwritten by topic | ||
| t.Run("POST /createRoom makes a room with a topic via initial_state overwritten by topic", func(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
For my own reference, this behavior is spec'ed in the /createRoom endpoint, https://spec.matrix.org/v1.14/client-server-api/#post_matrixclientv3createroom
The server MUST apply the normal state resolution rules when creating the new room, including checking power levels for each event. It MUST apply the events implied by the request in the following order:
[...]
6. Events listed ininitial_state, in the order that they are listed.
7. Events implied bynameandtopic(m.room.nameandm.room.topicstate events).
[...]
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
MadLittleMods
requested changes
Jul 10, 2025
This reverts commit 07cf34e.
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
MadLittleMods
requested changes
Jul 14, 2025
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
MadLittleMods
approved these changes
Jul 15, 2025
Collaborator
|
Thanks for adding Complement tests for this @Johennes 🐍 |
jevolk
pushed a commit
to matrix-construct/complement
that referenced
this pull request
Jul 22, 2025
Rich topics landed with Matrix 1.15. These tests were broken out from https://github.com/element-hq/synapse/pull/18195/files#r2170245892. Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rich topics landed with Matrix 1.15. These tests were broken out from https://github.com/element-hq/synapse/pull/18195/files#r2170245892.
Pull Request Checklist