Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Implement /thirdparty endpoints#2831

Merged
neilalexander merged 7 commits into
mainfrom
s7evink/thirdparty
Nov 2, 2022
Merged

Implement /thirdparty endpoints#2831
neilalexander merged 7 commits into
mainfrom
s7evink/thirdparty

Conversation

@S7evinK
Copy link
Copy Markdown
Contributor

@S7evinK S7evinK commented Oct 26, 2022

Implements the following endpoints

GET /_matrix/client/v3/thirdparty/protocols
GET /_matrix/client/v3/thirdparty/protocols/{protocol}
GET /_matrix/client/v3/thirdparty/location
GET /_matrix/client/v3/thirdparty/location/{protocol}
GET /_matrix/client/v3/thirdparty/user
GET /_matrix/client/v3/thirdparty/user/{protocol}

@S7evinK S7evinK added C-App-Services are-we-synapse-yet This issue or PR involves Sytests in AWSY labels Oct 26, 2022
@S7evinK S7evinK marked this pull request as ready for review October 26, 2022 13:35
@S7evinK S7evinK requested a review from a team as a code owner October 26, 2022 13:35
@neilalexander
Copy link
Copy Markdown
Contributor

Looks like there are newly passing tests for sytest-whitelist.

@S7evinK
Copy link
Copy Markdown
Contributor Author

S7evinK commented Oct 26, 2022

Yep, but I'm not yet happy with the cache, as it is only refreshed when calling /protocol without a protocol.

@S7evinK
Copy link
Copy Markdown
Contributor Author

S7evinK commented Oct 27, 2022

Oh, and this would need matrix-org/sytest#1310, which currently breaks the tests for Synapse.
Even with the fallback implemented, the tests fail due to Destroying unresponded HTTP request to /appservs/1/_matrix/app/v1/thirdparty/protocol/ymca

@neilalexander neilalexander merged commit b367cfe into main Nov 2, 2022
@neilalexander neilalexander deleted the s7evink/thirdparty branch November 2, 2022 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

are-we-synapse-yet This issue or PR involves Sytests in AWSY C-App-Services

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants