Use stable identifiers from MSC3706 (Faster joins)#350
Conversation
Codecov ReportBase: 48.15% // Head: 48.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 48.15% 48.19% +0.03%
==========================================
Files 37 37
Lines 5889 5889
==========================================
+ Hits 2836 2838 +2
+ Misses 2785 2783 -2
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| Event RawJSON `json:"event,omitempty"` | ||
| // true if the state is incomplete | ||
| PartialState bool `json:"org.matrix.msc3706.partial_state"` | ||
| PartialState bool `json:"members_omitted"` |
There was a problem hiding this comment.
I kinda wonder if we should rename the struct field while we're here. It'll break compatibility with any apps using it, but there doesn't seem to be any advantage to delaying it?
There was a problem hiding this comment.
Not sure what the done thing is in GMSL, but I'm persuaded.
kegsay
left a comment
kegsay
left a comment
There was a problem hiding this comment.
Don't worry about backwards compat - we don't use faster joins in Dendrite yet.
3 participants
I haven't made any effort to maintain backwards compatibility (unlike in matrix-org/synapse#14832). I'm happy to do so if needed, but might need some guidance.
Synapse issue: matrix-org/synapse#14828
Synapse PR: matrix-org/synapse#14832
Complement PR: matrix-org/complement#583
GMSL PR: #350
MSC: matrix-org/matrix-spec-proposals#3706
Spec diff: matrix-org/matrix-spec#1393
Pull Request Checklist
Signed-off-by:
David Robertson <davidr@element.io>