Conform to base-x >= 3.0.5 API#810
Closed
jryans wants to merge 1 commit into
Closed
Conversation
The library `base-x` now expects an explicit `Buffer` instance, so let's change to that to make things easier. (Alternatively, we could pin to a previous version, but it's a small tweak to make.) Signed-off-by: J. Ryan Stinnett <jryans@gmail.com>
turt2live
approved these changes
Dec 18, 2018
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
I'm assuming it has been tested
Collaborator
Author
|
Yes, tests pass locally and I manually tested the Riot feature that uses this code path. |
Collaborator
Author
|
Ah... Looks like this approach using the newer version means ES6 deps again... Probably better to pin instead then for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library
base-xnow expects an explicitBufferinstance, so let's changeto that to make things easier. (Alternatively, we could pin to a previous
version, but it's a small tweak to make.)
Signed-off-by: J. Ryan Stinnett jryans@gmail.com