This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Copy Button overlapping with Copyable Text resolved.#10226
Closed
Adesh-Pandey wants to merge 3 commits into
Closed
Copy Button overlapping with Copyable Text resolved.#10226Adesh-Pandey wants to merge 3 commits into
Adesh-Pandey wants to merge 3 commits into
Conversation
…ecially to solve the overlapping problem in the access token div
…ecially to solve the overlapping problem in the access token div and replaced the scroll with auto
|
Thanks for opening this pull request, unfortunately we do not accept contributions from the main branch of your fork, please re-open once you switch to an alternative branch for everyone's sanity. See https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md |
github-actions
Bot
added
the
Z-Community-PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
On element-web, although Pull Request solves the overflowing issue for the specific access token section, it fails when screen size is around 12 inches. In order to make the solution less of a fix for this specific case, I modified the main CSS classes that these copy button and the text div were using. This resulted changes on multiple section of the app ( room sharing link, room message sharing link, access token , room information ) which works perfectly fine in all of those cases while solving the overlapping problem in the access token section.
Before :
After :
Room information (Room settings -> Advanced )
Share room message
Share room
Access Token
Bug Fixes:
Notes: Fix a bug that was generated while solving the issue (element-hq/element-web#24023) .
Signed-off-by: Adesh Pandey adeshpandey836@gmail.com
T-task
-->
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.