This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Change the category of a test from message displaying to configure room#10449
Merged
Conversation
… room' The test is not related to messages, instead it checks an element inside GELS (generic event list summary) on a configured room without a message Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…e comment Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
Bot
added
Z-Community-PR
germain-gg
approved these changes
Mar 28, 2023
Contributor
Author
|
@gsouquet Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to change a category of a test on
timeline.spec.tsfrom "message displaying" to "configure room". Since the test is related to GELS (generic event list summary) without sending / displaying a message, it should be placed inside the latter category.It also adds a comment on the test as it has become not quite clear what this test checks. The test was added with #9037.
type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.