This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove an obsolete style block related to highlighting from _IRCLayout.pcss#10451
Merged
Conversation
…t.pcss Initially it has been added with this commit 67249e1 for the implementation of IRC layout, but the border declarations for highlighting were removed with this commit 3a2aa9d to replace the 'border-left' declaration with the 'box-shadow' declaration. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
Bot
added
Z-Community-PR
weeman1337
approved these changes
Apr 4, 2023
Contributor
weeman1337
left a comment
weeman1337
left a comment
There was a problem hiding this comment.
LGTM 👍
Thank you for your contribution @luixxiul
Contributor
|
@luixxiul can you push an empty commit to trigger CI? It would speed things up if you can enable „Allow edit from maintainers“ on your PRs. |
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an obsolete style block related to highlighting from
_IRCLayout.pcssInitially it has been added with this commit for the implementation of IRC layout on #4531, but the border declarations for highlighting on
_EventTile.scss, which the style block on_IRCLayout.pcsshas been expected to cancel, were replaced by this commit on #7209 with ones based onbox-shadow.For reference, you could refer the current implementation from here.
type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.