This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove orphaned GenericError class#10500
Merged
Merged
Conversation
Originally introduced in #8329 All usages were removed in #9605 This error also has problems with showing tranlsated versions in the logs. Part of element-hq/element-web#9597 We should be using the new `UserFriendlyError` for this kind of thing anyway. Introduced in #10440
MadLittleMods
added
the
T-Task
3 tasks
weeman1337
approved these changes
Apr 4, 2023
Contributor
weeman1337
left a comment
weeman1337
left a comment
There was a problem hiding this comment.
Couldn't find any usage of GenericError in React SDK, EW and ED → 👍
Contributor
Author
|
Thanks for the review @weeman1337 🦡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove orphaned
GenericErrorclassGenericErroralso has problems with showing translated versions in the logs. Related to We log the translated version of several errors element-hq/element-web#9597UserFriendlyErrorfor this kind of thing anyway (introduced in ReplacenewTranslatableErrorwithUserFriendlyError(#10440 #10440)Checklist
Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.