Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Remove TODO comments about spacing variables#10695

Merged
germain-gg merged 6 commits into
matrix-org:developfrom
luixxiul:remove-todo-spacing
Jun 6, 2023
Merged

Remove TODO comments about spacing variables#10695
germain-gg merged 6 commits into
matrix-org:developfrom
luixxiul:remove-todo-spacing

Conversation

@luixxiul
Copy link
Copy Markdown
Contributor

@luixxiul luixxiul commented Apr 22, 2023 •
edited by github-actions Bot
Loading

This PR intends to remove TODO comments about spacing variables on _spacing.pcss, since they have been deprecated and should no longer be used.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions Bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 22, 2023
@luixxiul
Remove TODO comments about spacing variables
468dfb8 
The variables on _spacing.pcss have been deprecated by #10686
@luixxiul luixxiul marked this pull request as ready for review June 1, 2023 06:25
@luixxiul luixxiul requested a review from a team as a code owner June 1, 2023 06:25
germain-gg
germain-gg approved these changes Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@germain-gg germain-gg added this pull request to the merge queue Jun 2, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jun 2, 2023
@germain-gg germain-gg added this pull request to the merge queue Jun 2, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 2, 2023
@t3chguy t3chguy enabled auto-merge June 5, 2023 14:02
@t3chguy t3chguy added this pull request to the merge queue Jun 5, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 5, 2023
@germain-gg germain-gg added this pull request to the merge queue Jun 6, 2023
Merged via the queue into matrix-org:develop with commit d340fa8 Jun 6, 2023
@luixxiul luixxiul deleted the remove-todo-spacing branch June 6, 2023 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@germain-gg germain-gg germain-gg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luixxiul @germain-gg