Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add appearance-user-settings-tab.spec.ts#10697

Merged
weeman1337 merged 12 commits into
matrix-org:developfrom
luixxiul:test-appaearance-user-settings-tab
May 11, 2023
Merged

Add appearance-user-settings-tab.spec.ts#10697
weeman1337 merged 12 commits into
matrix-org:developfrom
luixxiul:test-appaearance-user-settings-tab

Conversation

@luixxiul
Copy link
Copy Markdown
Contributor

@luixxiul luixxiul commented Apr 22, 2023

Closes element-hq/element-web#25181

With this PR, four Percy tests are going to be added:

  • User settings tab - Appearance (advanced options collapsed)
  • User settings tab - Appearance (advanced options expanded)
  • Font size slider - smallest (13)
  • Font size slider - largest (18)

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions Bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 22, 2023
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul marked this pull request as ready for review April 23, 2023 13:18
@luixxiul luixxiul requested a review from a team as a code owner April 23, 2023 13:18
@luixxiul luixxiul requested review from artcodespace and dbkr April 23, 2023 13:18
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@dbkr dbkr added this pull request to the merge queue Apr 25, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 25, 2023
@artcodespace artcodespace removed their request for review April 25, 2023 12:22
// Select the last layout
cy.get(".mx_LayoutSwitcher_RadioButton").last().click();

// Assert that the layout selected is "IRC (Experimental)"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh this should be fixed..

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Copy link
Copy Markdown
Contributor Author

@dbkr Would you please re-add this PR to the merge queue?

@luixxiul luixxiul mentioned this pull request May 10, 2023
3 tasks
@weeman1337 weeman1337 added this pull request to the merge queue May 11, 2023
Merged via the queue into matrix-org:develop with commit 16ec3b5 May 11, 2023
@luixxiul luixxiul deleted the test-appaearance-user-settings-tab branch May 11, 2023 07:03
@luixxiul luixxiul restored the test-appaearance-user-settings-tab branch May 11, 2023 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create E2E tests of Appearance user settings tab

3 participants