This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add a snapshot for RoomHeaderButtons#10807
Merged
Merged
Conversation
github-actions
Bot
added
Z-Community-PR
luixxiul
commented
May 6, 2023
kerryarchibald
previously requested changes
May 9, 2023
robintown
approved these changes
May 12, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #10495
This PR suggests to add a Jest snapshot of
RoomHeaderButtonsbefore factoring style rules of_RightPanel.pcssrelated to the buttons, making it easier to review #10495, which is expected to introduce a large change of the class names.Ideally there should be a snapshot test which captures all of the buttons on
RoomHeaderincluding a call button for example, but since the main object of taking this snapshot is to save the pattern of the class names, to check whether they follow our naming policy, I think the snapshot ofRoomHeaderButtonsshould be sufficient for now, and should be better than nothing.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.