This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Edit room-header.spec.ts to check apps button#10934
Merged
Merged
Conversation
github-actions
Bot
added
Z-Community-PR
andybalaam
suggested changes
May 18, 2023
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks good, with one suggested change.
| .getPropertyValue("background-color"); // get "background-color" value | ||
|
|
||
| // Assert the value is equal to $accent == hex #0dbd8b == rgba(13, 189, 139) | ||
| expect(color).to.eq("rgb(13, 189, 139)"); |
Member
There was a problem hiding this comment.
Can we check for a CSS class instead of an exact colour? I wouldn't want our test to fail if we tweak the colours.
Even better would be to check for an aria-label that said it was selected, or something like that, but it might not exist...
Member
There was a problem hiding this comment.
aria-label that said it was selected
Aria labels shouldn't be used for that, aria-selected, aria-checked, aria-pressed etc should be used instead
Contributor
Author
There was a problem hiding this comment.
With cd41594 I replaced assertions related to color with aria-selected, hope this should be fine.
Contributor
Author
|
Thanks both of you for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #10495
This PR suggests to edit
room-header.spec.tsto check apps button for a widget on the room header. The code to display a widget is based onlayout.spec.ts.This PR intends to add two Percy snapshots:
Room header - with apps button (highlighted)Room header - with apps button (not highlighted)type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.