Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Update style rules for the indicator on the room header#10938

Closed
luixxiul wants to merge 8 commits into
matrix-org:developfrom
luixxiul:RoomHeader4
Closed

Update style rules for the indicator on the room header#10938
luixxiul wants to merge 8 commits into
matrix-org:developfrom
luixxiul:RoomHeader4

Conversation

@luixxiul
Copy link
Copy Markdown
Contributor

@luixxiul luixxiul commented May 18, 2023

For #10495

This PR intends to update style rules for the indicator on the room header by moving the rules to _RoomHeader.pcss and _animations.pcss, applying our naming policy to them and adding Jest snapshots to ensure the naming policy is applied properly for each type of the indicator (bold, gray, and red).

indicator

type: task

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions Bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 18, 2023
@luixxiul luixxiul marked this pull request as ready for review May 18, 2023 06:47
@luixxiul luixxiul requested a review from a team as a code owner May 18, 2023 06:47
@luixxiul luixxiul requested review from dbkr and t3chguy May 18, 2023 06:47
@luixxiul luixxiul closed this Jun 1, 2023
@luixxiul luixxiul deleted the RoomHeader4 branch June 1, 2023 14:51
@luixxiul
Copy link
Copy Markdown
Contributor Author

luixxiul commented Jun 4, 2023

Closed as the work will eventually be obsolete anyway and working on that area just wastes everyone's time. Including mine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant