This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add Cypress E2E test of general room settings tab with Percy snapshots#10997
Merged
Conversation
github-actions
Bot
added
Z-Community-PR
kerryarchibald
added
the
X-Needs-Percy
robintown
approved these changes
Jun 2, 2023
Member
robintown
left a comment
robintown
left a comment
There was a problem hiding this comment.
Thank you, this is really helpful.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
robintown
removed
the
X-Needs-Percy
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-web#25452
This PR suggests to add general-room-settings-tab.spec.ts for the room settings tab (General) with Percy snapshots to capture visual regressions like element-hq/element-web#25451 and element-hq/element-web#25455.
It is expected that the Percy will not take the snapshots as expected until #10947 is merged. Once it is merged, Percy should be able to take snapshots like below (with local addresses area collapsed and expanded):
type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.