Deprecate mixin ThreadSummaryIcon#11023
Conversation
github-actions
Bot
added
Z-Community-PR
| display: flex; | ||
| align-items: center; | ||
| column-gap: 8px; | ||
| margin-bottom: 8px; |
There was a problem hiding this comment.
Please note $spacing variables have been deprecated: #10686
|
I'm struggling to increase the test coverage. Any pointers would be appreciated. |
Rename mx_ThreadSummary_icon to mx_ThreadSummary_info
Looking into the Sonar Cloud report adding a Jest test for |
There was a problem hiding this comment.
Thank you @luixxiul . I think this is a very valuable contribution. 👍 Replacing these mask-based and pseudo-element icons with a component will help with the compound migration.
Can you have a look at the Jest tests? If you need assistance there let me know.
| color: $username-variant8-color; | ||
| } | ||
|
|
||
| .mx_Icon--thread { |
There was a problem hiding this comment.
Not mandatory since the current icon stuff is temporary until Compound arrives™
You could add mx_Icon_18 and mx_Icon_secondary-content here.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Closing as I am not quite sure how I should proceed from here… @weeman1337 thanks anyway for the review. |
2 participants
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.