This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Align inline buttons on FilteredDeviceListHeader on Sessions user settings tab#11067
Closed
luixxiul wants to merge 1 commit into
Closed
Align inline buttons on FilteredDeviceListHeader on Sessions user settings tab#11067luixxiul wants to merge 1 commit into
FilteredDeviceListHeader on Sessions user settings tab#11067luixxiul wants to merge 1 commit into
Conversation
github-actions
Bot
added
Z-Community-PR
…ettings tab only In order to avoid those values from being applied to the inline buttons on mx_FilteredDeviceListHeader
kerryarchibald
suggested changes
Jun 9, 2023
Contributor
kerryarchibald
left a comment
kerryarchibald
left a comment
There was a problem hiding this comment.
Thanks for working on this.
However this change causes buttons elsewhere to display incorrectly, like here in Room settings:
Contributor
Author
|
closing in favor of another proper solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#25545
Regressed by https://github.com/matrix-org/matrix-react-sdk/pull/10972/files#diff-0c6139dd8fb5707cd9ac7874d270d5a8df772679956e2f6e43f11a45494cf3e2R36-R39 (#10972)
Before:
After:
.mx_SettingsTab .mx_AccessibleButtonis a very broad selector and matches buttons on every settings tab. This PR intends to fix the issue by limiting the selector to have it match the buttons onGeneraluser settings tab which #10972 addressed. Since the selectormx_GeneralUserSettingsTabhas been deprecated,mx_tabpanel_USER_GENERAL_TABis used instead.It is technically possible to "fix" the issue by overriding the values with or without
!importantflag, but obviously it is the default values that should be modified, so that declarations for overriding them are not required in the first place.This fix is rather temporary. Later, a component can be created for buttons on
SettingsTabif needed, to normalize how the buttons are rendered there.Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: defect
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes
FilteredDeviceListHeaderon Sessions user settings tab (#11067). Fixes Sessions manager's inline action buttons are not aligned element-hq/element-web#25545. Contributed by @luixxiul.