Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Disable branch matching of @matrix-org/analytics-events, except for PRs#11186

Merged
t3chguy merged 5 commits into
developfrom
t3chguy/fetchdep-analytics-events
Jul 4, 2023
Merged

Disable branch matching of @matrix-org/analytics-events, except for PRs#11186
t3chguy merged 5 commits into
developfrom
t3chguy/fetchdep-analytics-events

Conversation

@t3chguy
Copy link
Copy Markdown
Member

@t3chguy t3chguy commented Jul 4, 2023 •
edited by github-actions Bot
Loading

Requires element-hq/element-web#25712

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 4, 2023
@t3chguy t3chguy requested a review from a team as a code owner July 4, 2023 08:36
@t3chguy t3chguy requested review from dbkr and weeman1337 July 4, 2023 08:36
@t3chguy t3chguy mentioned this pull request Jul 4, 2023
Merged
@t3chguy t3chguy merged commit 1a2d201 into develop Jul 4, 2023
@t3chguy t3chguy deleted the t3chguy/fetchdep-analytics-events branch July 4, 2023 16:14
@andybalaam andybalaam mentioned this pull request Jul 4, 2023
Merged
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Jul 4, 2023

Tweak branch matching to allow not applying outside of PRs for matrix-analytics-events

I'm struggling to parse this. I think it means: we will no longer apply branch matching, except on PRs for https://github.com/matrix-org/matrix-analytics-events?

@t3chguy
Copy link
Copy Markdown
Member Author

t3chguy commented Jul 6, 2023

@richvdh yup. English hard

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Jul 6, 2023

If we're not doing branch matching any more, that seems like big news?

@t3chguy
Copy link
Copy Markdown
Member Author

t3chguy commented Jul 6, 2023 •
edited
Loading

@richvdh sorry maybe its once again misunderstood.

We still branch match, this just uses the @matrix-org/analytics-events version from yarn.lock on develop (outside of PRs) rather than using the main branch there as it did before. Turning off branch matching for that one project outside of PRs. Matching develop between EW + react-sdk + js-sdk is unchanged. Branch matching in PRs is unchanged

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Jul 6, 2023

"Disable branch matching of @matrix-org/analytics-events, except for PRs" ?

@t3chguy t3chguy changed the title Tweak branch matching to allow not applying outside of PRs for matrix-analytics-events Disable branch matching of @matrix-org/analytics-events, except for PRs Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@weeman1337 weeman1337 Awaiting requested review from weeman1337 weeman1337 is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@andybalaam andybalaam andybalaam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@t3chguy @richvdh @andybalaam