This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix: Clicking on members pile does nothing (Alternate fix)#11656
Closed
manancodes wants to merge 3 commits into
Closed
Fix: Clicking on members pile does nothing (Alternate fix)#11656manancodes wants to merge 3 commits into
manancodes wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
Z-Community-PR
github-actions
Bot
added
the
T-Defect
manancodes
changed the title
germain-gg
suggested changes
Sep 25, 2023
Contributor
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
Code looks good to me!
However you have a few tests that are failing and the updated logic here might warrant some new test cases to avoid regressions in the future
3 tasks
t3chguy
reviewed
Sep 25, 2023
| {overflow ? <span className="mx_FacePile_more" style={{ marginLeft: `calc(${size} * -0.2)` }} /> : null} | ||
| {overflow ? ( | ||
| <span | ||
| onClick={props.onClick} |
Member
There was a problem hiding this comment.
We also shouldn't use onClick on non-accessible elements
manancodes
changed the title
Contributor
|
Closing as #11657 is the correct behaviour we want to support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes element-hq/element-web#26164
Signed-off-by: Manan Sadana manancodes.dev@gmail.com
Clicking on a particular person should open his/her profile and clicking on the ...(more) button should open the list.
This was the behaviour before the fix:
Clicking on ...(more) button does nothing.
old.mov
Clicking user profile button does nothing.
old.mov
And this is the behaviour after the fix:
Clicking on ...(more) button opens list of users.
new.mov
Clicking user profile opens user profile.
new.mov
Type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes