This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Downgrade Cypress to v12.#11692
Merged
Merged
Conversation
andybalaam
added
the
T-Task
3 tasks
t3chguy
approved these changes
Oct 2, 2023
Member
Author
|
Force-merged since this is blocking everything else that might otherwise be in the merge queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(On the understanding that v12 will continue to allow us to use the sorry-cypress service for balancing test parallelisation.)
The upgrade PR to v13 contained config changes which I have attempted to revert, but the config has changed a little since then so this is worthy of close checking.
The upgrade PR also contained a fix to a spotlight test, which we think was needed anyway, and not related to upgrade. This PR does not revert that fix, and the tests appear to pass, so we think that's ok.
Reverts "Update dependency cypress to v13 (#11570)" This reverts commit 35a6595.
This change is marked as an internal change (Task), so will not be included in the changelog.