This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Ensure backup settings in playwright#12097
Closed
BillCarsonFr wants to merge 3 commits into
Closed
Conversation
BillCarsonFr
added
the
T-Task
BillCarsonFr
commented
Jan 3, 2024
Member
|
@BillCarsonFr I'm going to close this for now as it seems a bit stuck. We can reopen if we get back to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Improve the e2e crypto test and ensure that the backup is correctly configured after verification.
It will ensure that the backup version is as expected, and that the backup can be used to import keys (active), and to export (decryption key known)
The test will fail when verifying with passphrase/key until this react PR is reverted
This change is marked as an internal change (Task), so will not be included in the changelog.