This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Support m.login.terms during registration#2221
Merged
Merged
Conversation
bwindels
reviewed
Oct 16, 2018
| // Pick a language based on the user's language, falling back to english, | ||
| // and finally to the first language available. If there's still no policy | ||
| // available then the homeserver isn't respecting the spec. | ||
| const availableLangs = Object.keys(policy).filter(e => e !== "version"); |
Contributor
There was a problem hiding this comment.
Nit: move inside if below so it's only done when needed. Since you're only using the first one, could use find instead of filter.
| // available then the homeserver isn't respecting the spec. | ||
| const availableLangs = Object.keys(policy).filter(e => e !== "version"); | ||
| let langPolicy = policy[prefLang]; | ||
| if (!langPolicy) langPolicy = "en"; |
Contributor
There was a problem hiding this comment.
Seems like the code below assumes langPolicy is an object. Should this be policy.en?
bwindels
approved these changes
Oct 16, 2018
Member
Author
|
The travis-ci builds passed more than 5 minutes ago, but the commit status didn't make it here - merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#7168
Requires matrix-org/synapse#4004
Full spec: matrix-org/matrix-spec-proposals#1692