This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Passphrase Support for e2e backups#2283
Merged
Merged
Conversation
Add passphrase support to backup creation stage
Member
Author
turt2live
suggested changes
Nov 21, 2018
|
|
||
| _onPassPhraseConfirmKeyPress: function(e) { | ||
| if (e.key === 'Enter') { | ||
| this._onPassPhraseConfirmNextClick(); |
Member
There was a problem hiding this comment.
all the keydown handlers look to give the user a way to submit even when the "next" button is disabled. Should probably have a condition either here or in the click handler to check for that condition.
| <p> | ||
| Type in your Recovery Passphrase to confirm you remember it. | ||
| If it helps, add it to your password manager or store it | ||
| somewhere safe. |
| const DialogButtons = sdk.getComponent('views.elements.DialogButtons'); | ||
| return <div> | ||
| Without setting up Secure Message Recovery, you won't be able to restore your | ||
| encrypted message history if you log out or use another device. |
Member
Author
|
right, that should be better |
turt2live
approved these changes
Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.