This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add target="_blank" to links that don't have it#2496
Merged
Conversation
This is now more of a problem in the Electron app because of electron/electron#8841 but is still annoying in the webapp if you're taken away from your chat client. Exception is the SSO link, as commented (issue filed at element-hq/element-web#8247). Fixes element-hq/element-web#8226
turt2live
approved these changes
Jan 24, 2019
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
lgtm assuming tests go green. Looks like there's a bit of a backlog though :(
jryans
reviewed
Jan 24, 2019
| return ( | ||
| <div className="mx_AuthFooter"> | ||
| <a href="https://matrix.org">{ _t("powered by Matrix") }</a> | ||
| <a href="https://matrix.org" target="_blank" rel="noopener">{ _t("powered by Matrix") }</a> |
Collaborator
There was a problem hiding this comment.
This link is replaced with more links in riot-web, so you may want an additional PR there as well.
dbkr
added a commit
to element-hq/element-web
that referenced
this pull request
Jan 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is now more of a problem in the Electron app because of
electron/electron#8841 but is still
annoying in the webapp if you're taken away from your chat client.
Exception is the SSO link, as commented (issue filed at
element-hq/element-web#8247).
Fixes element-hq/element-web#8226