Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Iterate upon the room upgrade warning bar#2518

Merged
turt2live merged 2 commits into
experimentalfrom
travis/rver-cap-support
Jan 29, 2019
Merged

Iterate upon the room upgrade warning bar#2518
turt2live merged 2 commits into
experimentalfrom
travis/rver-cap-support

Conversation

@turt2live
Copy link
Copy Markdown
Member

@turt2live turt2live commented Jan 29, 2019

Part of element-hq/element-web#8251
Endpoint requires matrix-org/synapse#4472
Please review with matrix-org/matrix-js-sdk#830


This lessens the warning for unstable-but-not-official versions while still communicating that the version is unstable. In the future, we may want to make this state dismissable.

In the gif:

  • The room is on room version 1 (hardcoded to be "unstable" and non-default for demonstration purposes)
  • Upgraded to a known unstable version (that isn't in the spec) - this isn't a critical failure, but something we should warn the user about
  • Upgraded to a known safe version

room-upgrades

This lessens the warning for unstable-but-not-official versions while still communicating that the version is unstable. In the future, we may want to make this state dismissable.
@turt2live turt2live requested a review from a team January 29, 2019 01:57
@dbkr dbkr self-assigned this Jan 29, 2019
@turt2live turt2live merged commit a16eb30 into experimental Jan 29, 2019
@turt2live turt2live deleted the travis/rver-cap-support branch January 29, 2019 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants