This repository was archived by the owner on Sep 11, 2024. It is now read-only.
URL previewing support#260
Merged
Merged
Conversation
This was referenced Apr 3, 2016
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| thumbHeight: function(fullWidth, fullHeight, thumbWidth, thumbHeight) { |
Member
There was a problem hiding this comment.
Now that this is a public function, it would be nice to give this a comment saying what it does and what the parameters mean. How does its result relate to the thumbHeight param? Which of the params are allowed to be undefined? I could figure it out, but I shouldn't have to.
Member
Author
|
@richvdh PTAL - a few bits aren't resolved yet but are pending more feedback. |
Member
|
So I think remaining things here are:
|
…s PR review request
…on vdh's PR feedback
Member
Author
|
@richvdh done; feels much nicer to me. PTAL |
| @@ -405,7 +405,7 @@ module.exports = React.createClass({ | |||
| var scrollPanel = this.refs.scrollPanel; | |||
| if (scrollPanel) { | |||
| scrollPanel.checkScroll(); | |||
Member
There was a problem hiding this comment.
you don't need to do checkScroll as well as forceUpdate.
Member
Author
|
@richvdh PTAL again? |
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a set of PRs spanning vector-web, matrix-react-sdk, matrix-js-sdk and synapse.
See also element-hq/element-web#1343