This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Clarify devices affected by notification settings#2828
Merged
Conversation
This clarifies that the notification settings only apply to the current device. This also tries to apply the spirit of matrix-org#1995 (authored by @aidalgol) which wanted to remove "web" from the label, since there's also a desktop client.
jryans
force-pushed
the
notification-labels
branch
from
45e6e49 to
f8dce87
Compare
Collaborator
Author
Good idea! I updated the commit and PR to mention them. (I did not use the native Git "author" line since my change is a bit different, and I don't want imply they would have done the same thing.) |
su-ex
added a commit
to SchildiChat/matrix-react-sdk
that referenced
this pull request
Nov 4, 2022
* Fix default behavior of Room.getBlacklistUnverifiedDevices ([\matrix-org#2830](matrix-org/matrix-js-sdk#2830)). Contributed by @duxovni. * Catch server versions API call exception when starting the client ([\matrix-org#2828](matrix-org/matrix-js-sdk#2828)). Fixes element-hq/element-web#23634. * Fix authedRequest including `Authorization: Bearer undefined` for password resets ([\matrix-org#2822](matrix-org/matrix-js-sdk#2822)). Fixes element-hq/element-web#23655.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This clarifies that the notification settings only apply to the current device.
This also tries to apply the spirit of #1995 (authored by @aidalgol) which wanted to remove "web" from the label, since there's also a desktop client.